The Higher Education and Research forge

Home My Page Projects Code Snippets Project Openings Développement de WIMS
Summary Activity Forums Tracker Tasks Docs Surveys News SCM Files Listes Sympa

Forum: developers

Monitor Forum | Start New Thread Start New Thread
RE: bug in userscore module [ Reply ]
By: joke evers on 2016-09-27 06:13
[forum:17645]
correction: It works fine for me now !
I just tested your latest version of keyword.proc
(and it's good that wims flags an error , if asked too much !)
thanks,
Joke

RE: bug in userscore module [ Reply ]
By: Bernadette Perrin-Riou on 2016-09-27 06:09
[forum:17644]
Have you tested the commit of this night ? It solves the point 1 of my comment.

Bernadette

PS. I will do a release on thursday.

RE: bug in userscore module [ Reply ]
By: joke evers on 2016-09-27 05:54
[forum:17643]
The problem is:
in a ¨busy¨ class , I can not even enter the csv part of the userscore module.
So there is no way to configure what things should be in the spreadsheet data...
(in my c.tar.gz , just try class=1100005/33)


RE: bug in userscore module [ Reply ]
By: Bernadette Perrin-Riou on 2016-09-26 22:57
[forum:17641]
I knew that it is not possible to ask all indicators of all exercises in all sheets,
but don't realize that there is already a problem when opening the csv module.

What can be done
1- easily, asking for the names only when it is asked (so after having the interface
for csv), it should have be done before !

2- allow to ask allsheetexo only for one sheet (so transform the checkbox by radio buttons).
Anyway, who wants to have 300 columns in a spreadsheet ?

3- the other way is to increase the number VARNAME_LEN 32768
(multiply by 100 should solve some problems as I can try, thanks to test ). But perhaps, some other troubles will appear ! The number of students is not a problem as I can see only the number of columns and the length of the title of the sheets (not quite sure).

4 - finally try to think of this csv part in a different way ?

I will do 1) and 2) quickly. Then we can test more and see what to do for the following.

By the way, we increase also the number of variables with the multilanguage modules.


RE: bug in userscore module [ Reply ]
By: Bernadette Perrin-Riou on 2016-09-26 08:37
[forum:17639]
As you use it, it creates 26*15 variables and perhaps much more if you want the indicators.
So the number of title variables is too big. I think it is the reason (but don't look at it
precisely).

I will try to fix by creating only one variable by sheet for example (but
one must be careful with commas).

Bernadette
The message error comes from
if(_varnameptr+nlen+1>_varnamebuf+VARNAME_LEN) {
module_error("variable_name_buffer_overflow"); return -1;
}
in var.c

bug in userscore module [ Reply ]
By: joke evers on 2016-09-26 08:30
[forum:17638]
wims gives the next error when -in any case- trying to produce a csv file
(on both linux and bsd servers)
#########
ERROR.

wims has detected an error in the module 'adm/class/userscore'.

In file 'csv/keyword.proc', line 72: variable_name_buffer_overflow.
#########
A class has typical
20-25 pupils
20 worksheets (and 6 exams)
a worksheet has typical 15-20 exercises

This was true in version 4.12 and in the latest svn version 4.13x

I've tried to debug this but it seems highly complicated for me...
(I don't have a clue...probably the variavle $se gets too big?)

Can anyone reproduce this error ?